[7.0] Fix the tiering delay to account for changing IL/native code versions during the delay #78669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsions during the delay - Port of dotnet#78668 - Added a check to see if the currently active native code version has a code entry point Fixes dotnet#77973
|
@kouvel I posted the same comment in the 6.0 PR, but adding it here too for clarity: for the January servicing release, we only have a window of one day to merge backports (from Nov. 29th to Nov. 30th). For that reason, I'm asking all backport submitters to make sure the PR is ready for me to just hit the merge button on that day. If this is ready, please ask @jeffschwMSFT if he approves the backport. If approved, then: |
jeffschwMSFT
approved these changes
Nov 23, 2022
jeffschwMSFT
added
the
Servicing-consider
mangod9
approved these changes
Nov 24, 2022
noahfalk
approved these changes
Nov 24, 2022
jeffschwMSFT
added
Servicing-approved
davmason
approved these changes
Nov 28, 2022
|
Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. CI is green. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77973
Customer Impact
Apps that use profiler APIs to modify a method's IL may occasionally crash. If a new IL code version is added to a method while it's queued for call counting during the tiering delay, after the delay expires a call counting stub may be created that when called, would cause the app to crash. A workaround is to disable tiered compilation.
Regression?
No
Testing
Reproed the issue by inducing the timing with code changes and verified the fix. Scanned over the few other paths where call counting stubs would be created and verified that all of them guarantee a non-null code entry point for the method.
Risk
Low